IT-682: Update action.yml to remove grep for drush error#3
Conversation
|
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
action.yml (4)
55-55: Fix trailing whitespace.Yamllint flags a trailing space after the command.
- ddev install-site + ddev install-site
53-56: Harden the shell and confirm failure semantics.Relying on exit codes is fine; please confirm
ddev install-site/Drush return non‑zero on failure in your cases. Also, use stricter shell options for robustness.- set -e + set -euo pipefail
55-55: Optional: keep logs for debugging without custom greps.If you want install logs when failures occur, tee to a file (with pipefail above) and upload as an artifact in the calling workflow.
- ddev install-site + ddev install-site 2>&1 | tee install-site.log
39-46: Mask sensitive inputs in logs.Action inputs aren’t auto-masked. Add mask directives before writing keys/auth to disk to reduce exposure in logs.
run: | mkdir -p .ddev/homeadditions/.ssh + echo "::add-mask::${{ inputs.ssh-key }}" echo "${{ inputs.ssh-key }}" > .ddev/homeadditions/.ssh/id_rsa chmod 700 .ddev/homeadditions/.ssh chmod 600 .ddev/homeadditions/.ssh/id_rsa mkdir -p .ddev/homeadditions/.composer + echo "::add-mask::${{ inputs.composer-auth }}" echo '${{ inputs.composer-auth }}' > .ddev/homeadditions/.composer/auth.json
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
action.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
action.yml
[error] 55-55: trailing spaces
(trailing-spaces)
2 participants
Summary by CodeRabbit